His uniform is pre 1940 as it was replaced by battledress. As a Fife and Forfar Yeoman he was in a Scottish Territorial Army unit which ties in with his birthplace. The clothing and haircut match the 1930s. Have you tried to find them on the 1939 register?