Based solely on the uniform, I would say any time between the wars. Service Dress was being phased out in the 1930s in favour of battledress and had mostly disappeared by 1940.
If you could show us an enlargement of the badges, someone might know the regiment.
A.